Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Validated.filter #605

Merged
merged 2 commits into from
Nov 9, 2015
Merged

Remove Validated.filter #605

merged 2 commits into from
Nov 9, 2015

Commits on Nov 7, 2015

  1. Remove Validated.filter 

    I think this was leftover from copy/paste from `Xor`. It mentions that
it's useful when using `Validated` in for-comprehensions, but you can't
actually use `Validated` in for-comprehensions since it doesn't have a
`flatMap` method :).

Also, `Xor` no longer has a `filter` method. It was removed in typelevel#276
since using the monoid zero when the predicate doesn't match is rather
arbitrary and can lead to surprises. I think we should follow that
precedent for `Validated`.
    @ceedubs
    ceedubs committed Nov 7, 2015
    Configuration menu
    Copy the full SHA
    71fcdc0 View commit details
    Browse the repository at this point in the history

  2. Remove Validated.filter tests

    @ceedubs
    ceedubs committed Nov 7, 2015
    Configuration menu
    Copy the full SHA
    c0deecf View commit details
    Browse the repository at this point in the history