Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OptionT#unlessM #4519

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Add OptionT#unlessM #4519

merged 1 commit into from
Sep 19, 2023

Conversation

m50d
Copy link
Contributor

@m50d m50d commented Sep 19, 2023 •
edited
Loading

Perhaps I'm missing something, but this seems like an obvious counterpart to whenM and I was surprised to not find it? There are already unlessF and unlessK but no unlessM.

armanbilge
armanbilge approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice one! I guess it was an oversight that it's missing.

satorg
satorg approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@satorg satorg merged commit a6a3e38 into typelevel:main Sep 19, 2023
16 checks passed
@m50d m50d deleted the unlessm branch September 19, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

@satorg satorg satorg approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m50d @armanbilge @satorg