Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump base version to 2.10 #4341

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Bump base version to 2.10 #4341

merged 1 commit into from
Nov 13, 2022

Conversation

armanbilge
Copy link
Member

No description provided.

@armanbilge armanbilge added the behind-the-scenes appreciated, but not user-facing label Nov 12, 2022
@armanbilge armanbilge merged commit 360b773 into main Nov 13, 2022
@armanbilge armanbilge deleted the pr/base-ver-2.10 branch November 13, 2022 00:06
@djspiewak
Copy link
Member

Out of curiosity, why bump eagerly? Part of the original concept behind using base version is that you can wait to bump it until you actually add a source-breaking change.

@armanbilge
Copy link
Member Author

@djspiewak right, same reasoning when we bumped to 2.9:

Cats rarely release patches and we have a number of open PRs that would require a bump anyway. So bumping this pro-actively, and we can start a series/2.8 branch if anything crops up.

@armanbilge
Copy link
Member Author

armanbilge commented Nov 13, 2022

At a glance 15/26 of the currently open PRs are source-breaking and would require a bump anyway. Most of the ones that don't are docs PRs.

@djspiewak
Copy link
Member

Gotcha. Still feels slightly odd to do it here rather than bumping together with the change that actually breaks compatibility, but whatever works!

@armanbilge
Copy link
Member Author

armanbilge commented Nov 13, 2022

I agree :) what's missing is tooling support: if CI doesn't enforce the minor bump it is harder to remember it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behind-the-scenes appreciated, but not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants