Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary MiMa filters #4204

Merged
merged 7 commits into from
May 8, 2022
Merged

Remove unnecessary MiMa filters #4204

merged 7 commits into from
May 8, 2022

Conversation

armanbilge
Copy link
Member

Closes #3719.

@armanbilge
Copy link
Member Author

Darn, the change is binary-compatible but semantically-incompatible.

@armanbilge armanbilge changed the title Fix bincompat, remove unnecessary filters Remove unnecessary filters May 7, 2022
@armanbilge armanbilge marked this pull request as draft May 7, 2022 07:08
@armanbilge armanbilge changed the title Remove unnecessary filters Remove unnecessary MiMa filters May 7, 2022
@armanbilge armanbilge mentioned this pull request May 7, 2022
Closed
armanbilge
armanbilge commented May 7, 2022
View reviewed changes
mima.sbt Outdated Show resolved Hide resolved
@armanbilge armanbilge marked this pull request as ready for review May 7, 2022 07:52
danicheg
danicheg approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green, so green light on merging from me 👍🏻

@armanbilge armanbilge merged commit 1d48bc9 into typelevel:main May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnynek johnynek johnynek approved these changes

@danicheg danicheg danicheg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential trait encoding binary compatibility issues
3 participants
@armanbilge @johnynek @danicheg