Make catsInstancesForIdCompat2_6_1 package-private
#4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satorg
reviewed
Apr 19, 2022
| @@ -128,7 +128,7 @@ object Invariant extends ScalaVersionSpecificInvariantInstances with InvariantIn | |||
| cats.catsInstancesForId | |||
| @deprecated("Added for bincompat", "2.8.0") | |||
| @cats.compat.targetName("catsInstancesForId") | |||
There was a problem hiding this comment.
Could you provide some details on how this guy is supposed to work please? I think it might help me with my work in #4187.
There was a problem hiding this comment.
Definitely, do you mean about the compat thing or the semantics of targetName which is a Scala 3 feature? You can see how it works in #4143 (comment).
rossabaker
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially kept this public, because usually static forwarders go away when a method is package-private, and we need them for complete binary-compatibility. However, I learned in scala/scala3#10842 that this is not the case on Scala 3. So, there is no reason to leak this method in the public API.