Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4045 Add missing else keyword to example #4046

Merged
merged 1 commit into from
Nov 18, 2021
Merged

4045 Add missing else keyword to example #4046

merged 1 commit into from
Nov 18, 2021

Conversation

steve-e
Copy link
Contributor

@steve-e steve-e commented Nov 17, 2021

Minor correction to an example in documentation for ApplicativeError. Fixes issue 4045

satorg
satorg approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, without else this example does not make any sense.

rossabaker
rossabaker approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rossabaker rossabaker merged commit 0b01db8 into typelevel:main Nov 18, 2021
@steve-e steve-e deleted the 4045-applicative-error-example-fix branch November 22, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@satorg satorg satorg approved these changes

@rossabaker rossabaker rossabaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ApplicativeError final example - raiseError ignored
4 participants
@steve-e @rossabaker @satorg @LukaJCB