Configure microsite image directory #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
added a commit
that referenced
this pull request
Aug 5, 2021
This was referenced Aug 5, 2021
|
Thanks so much @rossabaker!! FYI there are still some broken non-sponsor images with dubious looking URLs like https://placehold.it/15/f03c15/000000?text=+. Maybe I'll just submit a patch to remove them, as they don't look particularly necessary. |
|
That sounds good. For whatever reason, I'm not seeing them in the source. Perhaps they were there when the site was published with the last release? |
djspiewak
approved these changes
Aug 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3690. I'm just trying to put out a fire, and circling back with a more thoughtful approach from someone who understands jekyll would be good.
Concerns:
docswhile the output is incats-docs.