RepresentableStoreT #3836
Merged
RepresentableStoreT #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritschwumm
reviewed
Mar 28, 2021
larsrh
approved these changes
Apr 1, 2021
|
@larsrh thanks for reviewing! Is this just waiting for someone else to look at it or do I need to do anything else? |
|
I was hoping to get another 👍 but I think this addition is good regardless 😄 |
😂 Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
RepresentableStoreT(co)monad-transformer. Unfortunately I don't think it's possible to unify the existingRepresentableStorewith this (by settingW = Id) due to bin-compat problems. If that is not the case then please do let me know!