another attempt at Cogen for (Finite)Duration #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Filippo Mariotti <barambani@users.noreply.github.com>
barambani
approved these changes
Feb 6, 2021
LukaJCB
reviewed
Feb 6, 2021
| case NANOSECONDS => 6128745701389500153L | ||
| }) | ||
| } | ||
| Cogen[Long].contramap(_.toNanos) |
There was a problem hiding this comment.
@larsrh this is the same as the one defined in ScalaCheck currently, so maybe we should just delete it?
There was a problem hiding this comment.
Excellent point. I just checked and ScalaCheck has all combinations of {Arbitrary, Cogen} and {Duration, FiniteDuration}. Should I delete them too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #3470 redux, although with another approach.
Contains code by @barambani to test the issue.
I've confirmed that the newly-added tests fail without the
Cogenchange.cc @TimWSpence