Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created documentation for monaderror, merged it with applicative erro… #3639

Merged
merged 2 commits into from
Dec 6, 2020

Conversation

dhinojosa
Copy link
Contributor

This is the documentation for MonadError which is merged into one document. Also didn't realize there is menu.yaml file which needed to be updated so I turned on the page for Monad and Applicative Error.

Daenyth
Daenyth previously approved these changes Oct 22, 2020
Copy link
Contributor

@Daenyth Daenyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

I think the liftTo on Either and Option for MonadError deserve a mention: For example someEither.liftTo[IO] is a very common pattern, that's worth being in the docs. But not worth blocking a merge on that detail. Anything is better than what we have today

docs/src/main/mdoc/typeclasses/applicativemonaderror.md Outdated Show resolved Hide resolved
Co-authored-by: Gavin Bisesi <Daenyth+github@gmail.com>
@codecov-io
Copy link

codecov-io commented Dec 6, 2020

Codecov Report

Merging #3639 (d23ff43) into master (5167734) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3639      +/-   ##
==========================================
- Coverage   90.28%   90.23%   -0.05%     
==========================================
  Files         391      391              
  Lines        8872     8861      -11     
  Branches      262      277      +15     
==========================================
- Hits         8010     7996      -14     
- Misses        862      865       +3     

Copy link
Contributor

@larsrh larsrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@larsrh larsrh merged commit 9f1191d into typelevel:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants