Enable breakout in functions nonEmptyTraverse_ and nonEmptySequence_ #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takayahilton
force-pushed
the
fix-nonemptytraverse_
branch
2 times, most recently
from
0492bbd
to
72aaf16
Compare
takayahilton
force-pushed
the
fix-nonemptytraverse_
branch
from
72aaf16
to
1470081
Compare
LukaJCB
previously approved these changes
Aug 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #3545 +/- ##
==========================================
- Coverage 91.32% 91.30% -0.03%
==========================================
Files 386 386
Lines 8592 8565 -27
Branches 269 248 -21
==========================================
- Hits 7847 7820 -27
Misses 745 745 |
johnynek
reviewed
Aug 3, 2020
| @@ -182,7 +182,7 @@ import scala.annotation.implicitNotFound | |||
| * the traversal. | |||
| */ | |||
| def nonEmptyTraverse_[G[_], A, B](fa: F[A])(f: A => G[B])(implicit G: Apply[G]): G[Unit] = | |||
| G.void(reduceLeftTo(fa)(f)((x, y) => G.map2(x, f(y))((_, b) => b))) | |||
| G.void(reduceRightTo(fa)(f)((x, y) => G.map2Eval(f(x), y)((_, b) => b)).value) | |||
There was a problem hiding this comment.
should we not void after each f? couldn't that be a win rather than voiding at the end?
f1 = f.andThen(G.void(_))
or:
val f1 = f.andThen(G.void(_))
G.void(reduceRightTo(fa)(f1)((x, y) => G.map2Eval(G.void(f(x)), y)((_, b) => b)).value)
takayahilton
force-pushed
the
fix-nonemptytraverse_
branch
from
4b78114
to
170c4b5
Compare
barambani
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #3015 #3498