Improve documentation for typeclasses #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
approved these changes
Jun 18, 2020
LukaJCB
approved these changes
Jun 18, 2020
kailuowang
approved these changes
Jun 18, 2020
|
Travis / Github hasn't been stable recently. The ci for this PR is ok (here) but the notification didn't work. I'm re-triggering the build on Travis side. |
|
It didn't work. I'm closing and reopening the PR to trigger the CI again. |
|
Maybe we should consider using GitHub actions at some point |
|
Yes, that's definitely an option. |
Codecov Report
@@ Coverage Diff @@
## master #3481 +/- ##
==========================================
- Coverage 91.77% 90.94% -0.84%
==========================================
Files 383 383
Lines 8394 8683 +289
Branches 205 205
==========================================
+ Hits 7704 7897 +193
- Misses 690 786 +96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small (opinionated) improvement.
I've just read the documentation for typeclasses on the microsite and I was very confused by the use of duplicate name
A. Although it compiles either way, I think this change will cause less confusion to future readers. Feel free to dismiss this PR if you feel different.