Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Simulacrum exclusion in POM #3430

Merged
merged 1 commit into from
May 24, 2020

Conversation

travisbrown
Copy link
Contributor

Previously we'd filtered the Simulacrum dependency (which is only needed at compile-time) by matching the artifact name with simulacrum_. In #3424 this changed, though, from simulacrum_2.x to simulacrum-scalafix-annotation_2.x. This PR fixes the filter. I've published locally and verified that the dependency isn't included in the POM, and that everything works at runtime (by running Circe's tests using the local snapshot).

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2020

Codecov Report

Merging #3430 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3430   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         381      381           
  Lines        8268     8268           
  Branches      225      225           
=======================================
  Hits         7577     7577           
  Misses        691      691           
Flag Coverage Δ
#scala_version_212 91.63% <ø> (ø)
#scala_version_213 91.41% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c067cac...235c89d. Read the comment docs.

@travisbrown travisbrown merged commit 6f27f07 into typelevel:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants