Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new method final #3429

Closed

Conversation

travisbrown
Copy link
Contributor

This is a minor thing to follow up on #3423, which introduces two new toNev methods but only makes one of them final. There are a lot of places where we missed the boat on making things final, and can't now because of bincompat, but for new methods like this I think we should try to do it consistently.

@travisbrown travisbrown requested a review from LukaJCB May 24, 2020 11:22
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2020

Codecov Report

Merging #3429 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3429   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         381      381           
  Lines        8268     8268           
  Branches      225      227    +2     
=======================================
  Hits         7577     7577           
  Misses        691      691           
Flag Coverage Δ
#scala_version_212 91.63% <ø> (ø)
#scala_version_213 91.41% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
core/src/main/scala/cats/data/NonEmptyList.scala 98.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c067cac...ea64749. Read the comment docs.

@saraiva132
Copy link
Contributor

saraiva132 commented May 24, 2020

NonEmptyList is a final class so there is no need for its methods to be final.

LazyNonEmptyList is not a final class. Perhaps there could be some considerations into making it final which would remove the need for its methods to be final (I believe most of them are but some are not).

@travisbrown
Copy link
Contributor Author

@saraiva132 Ah, thanks, I missed that! Agreed, it's not needed here.

@saraiva132
Copy link
Contributor

Np @travisbrown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants