-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EitherT and IorT constructors from Option with monadic default #3426
Add EitherT and IorT constructors from Option with monadic default #3426
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3426 +/- ##
==========================================
+ Coverage 91.64% 91.65% +0.01%
==========================================
Files 381 381
Lines 8268 8278 +10
Branches 225 225
==========================================
+ Hits 7577 7587 +10
Misses 691 691
Continue to review full report at Codecov.
|
a04e4e1
to
8bbb5f1
Compare
8bbb5f1
to
74a6bc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
update: I found the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you address my last comment?
Hi, @ivan-klass , sorry about the confusion, but another maintainer merged this PR while I was drafting the feedback. We are reverting the merge, would you mind resubmit this PR? I can re-add my feedback there. Thanks! |
Sure, will re-submit with addressed suggestion |
In practice the
OptionT[F, A]
=>EitherT[F, E, A]
transformation may also require the left to be calculated asF[E]
. I didn't find anything handy neither inOptionT
norEitherT
having to work-around with.leftSemiflatMap(identity)
likeor