Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak EitherT.pure and rightT to avoid a map call #3408

Merged
merged 1 commit into from
May 7, 2020

Conversation

joroKr21
Copy link
Member

@joroKr21 joroKr21 commented May 7, 2020

It's not necessary. Closes #3398

@codecov-io
Copy link

codecov-io commented May 7, 2020

Codecov Report

Merging #3408 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3408   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files         379      379           
  Lines        7981     7981           
  Branches      230      228    -2     
=======================================
  Hits         7399     7399           
  Misses        582      582           
Flag Coverage Δ
#scala_version_212 92.73% <100.00%> (ø)
#scala_version_213 92.49% <100.00%> (ø)
Impacted Files Coverage Δ
core/src/main/scala/cats/data/EitherT.scala 98.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb9df6...bc66442. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@kailuowang kailuowang merged commit 614cd71 into typelevel:master May 7, 2020
@joroKr21 joroKr21 deleted the eithert-tweak branch May 8, 2020 04:48
@travisbrown travisbrown added this to the 2.2.0-M2 milestone May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EitherT.pure does not call F.pure on the 'Right' value
5 participants