Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add List#scanLeftNel and List#scanRightNel #3239

Merged

Conversation

enzief
Copy link
Contributor

@enzief enzief commented Jan 6, 2020

.scanLeft result is always non-empty.

@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #3239 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3239      +/-   ##
==========================================
+ Coverage   93.05%   93.05%   +<.01%     
==========================================
  Files         376      376              
  Lines        7413     7415       +2     
  Branches      201      201              
==========================================
+ Hits         6898     6900       +2     
  Misses        515      515
Flag Coverage Δ
#scala_version_212 93.38% <100%> (ø) ⬆️
#scala_version_213 92.83% <100%> (ø) ⬆️
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/list.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f839716...0a14b8f. Read the comment docs.

@LukaJCB
Copy link
Member

LukaJCB commented Jan 6, 2020

Hey @enzief, thanks for the contribution, this seems pretty useful! Do you mind adding a test or two? Maybe a doctest? :) Much appreciated!

@rossabaker
Copy link
Member

I think a .scanRightNel would also be possible, if you're feeling ambitious. 😄

@enzief enzief changed the title add List#scanLeftNel add List#scanLeftNel and List#scanRightNel Jan 9, 2020
@enzief
Copy link
Contributor Author

enzief commented Jan 9, 2020

@LukaJCB @rossabaker another look please.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks.

@rossabaker rossabaker merged commit 5c72ffc into typelevel:master Jan 9, 2020
@travisbrown travisbrown added this to the 2.2.0-M1 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants