Fix NonEmptyChain.fromSeq signature on 2.12 #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…la.collection.immutable.Seq Similar to Chain.fromSeq()
Codecov Report
@@ Coverage Diff @@
## master #3133 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 376 376
Lines 7323 7323
Branches 190 206 +16
=======================================
Hits 6825 6825
Misses 498 498
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Nov 8, 2019
jackcviers
added a commit
to jackcviers/cats
that referenced
this pull request
Nov 9, 2019
* Adds scala version specific src directories * Backports PR typelevel#3133 to add scala 2.11 support
jackcviers
added a commit
to jackcviers/cats
that referenced
this pull request
Nov 10, 2019
* Adds scala version specific src directories * Backports PR typelevel#3133 to add scala 2.11 support * Brings scalafmt plugin and configs utd with master
jackcviers
added a commit
to jackcviers/cats
that referenced
this pull request
Nov 13, 2019
* Adds scala version specific src directories * Backports PR typelevel#3133 to add scala 2.11 support * Brings scalafmt plugin and configs utd with master
22 tasks
rossabaker
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes @gheine's commit from #2756, fixing #2718. The extra stuff I've added is to maintain bincompat. I'm not entirely convinced this is worth it.