-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cats.kernel.instances.finiteDuration package #3037
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3037 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 368 368
Lines 6975 6975
Branches 187 187
=======================================
Hits 6519 6519
Misses 456 456 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how this breaks source compatibility, so I think this could go in whenever, no?
Yeah, think so. |
Oh okay, now that I reparse your sentence, I think you probably just had a typo 👍 |
@LukaJCB Yeah, sorry, corrected. |
I know #3036 isn't a high priority but this is a trivial fix, and I'd personally like to see it in 2.0.0. The name matches
cats.instances.finiteDuration
.No tests, but there are no tests for the
duration
version, either. I confirmed that the following works:Shouldn't break source compatibility and definitely doesn't break bincompat.