Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant type annotation. #2980

Merged

Conversation

takayahilton
Copy link
Contributor

NonEmptyTraverse already inherits Reduceable.

@kailuowang
Copy link
Contributor

kailuowang commented Aug 8, 2019

I agree that if you already have NonEmptyTraversable then you don't need Reducible. The rest of the changes are probably misguided. Unfortunately there is quite some inconsistency and legacy complexty in the NonEmptyXXX datatypes, which is causing quite some confusion. I tried to unify them in a binary compatible way in this PR #2930, but the community cannot reach a consensus on what should be the best approach. To be fair, I reckon the risk of #2930 bringing even more confusion since it only unifies the code in 2.13 code branch, thus created more versions...

@takayahilton
Copy link
Contributor Author

Thanks, I'll just remove Reducible.

@takayahilton takayahilton force-pushed the remove-redundant-type-annotation branch from 86636fe to 2870dfc Compare August 8, 2019 15:00
@codecov-io
Copy link

Codecov Report

Merging #2980 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2980   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files         369      369           
  Lines        7068     7068           
  Branches      187      187           
=======================================
  Hits         6632     6632           
  Misses        436      436
Impacted Files Coverage Δ
core/src/main/scala/cats/data/NonEmptyList.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/data/NonEmptyVector.scala 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9379851...2870dfc. Read the comment docs.

@kailuowang kailuowang merged commit 803f61c into typelevel:master Aug 8, 2019
@kailuowang kailuowang added the bug label Aug 8, 2019
@takayahilton takayahilton deleted the remove-redundant-type-annotation branch August 8, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants