Implement local for Reader #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooohn
force-pushed
the
feature/local-for-reader
branch
2 times, most recently
from
953f839
to
ee84b77
Compare
jooohn
force-pushed
the
feature/local-for-reader
branch
from
ee84b77
to
98358ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #2917 +/- ##
=========================================
Coverage ? 94.27%
=========================================
Files ? 364
Lines ? 6953
Branches ? 197
=========================================
Hits ? 6555
Misses ? 398
Partials ? 0
Continue to review full report at Codecov.
|
LukaJCB
approved these changes
Jun 27, 2019
kailuowang
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2304
Same as this PR #2916, I implemented
localforReader.