fixed more warnings on 2.13 #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaJCB
previously approved these changes
Jun 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #2911 +/- ##
==========================================
+ Coverage 94.24% 94.26% +0.01%
==========================================
Files 363 364 +1
Lines 6951 6952 +1
Branches 184 188 +4
==========================================
+ Hits 6551 6553 +2
+ Misses 400 399 -1
Continue to review full report at Codecov.
|
milessabin
reviewed
Jun 26, 2019
LukaJCB
approved these changes
Jun 26, 2019
djspiewak
reviewed
Jun 26, 2019
|
|
||
| private[cats] object scalaVersionSpecific { | ||
| type LazyList[+A] = scala.LazyList[A] //this is needed only to avoid unused import warnings on Scala 2.13 | ||
| type IterableOnce[+A] = scala.IterableOnce[A] //this is needed only to avoid unused import warnings on Scala 2.13 |
djspiewak
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also made default Scala version 2.12, which helps for IDE integration.
Update: I removed ScalaStyle which is conflicting with scalafmt, I see no reason to maintain both.