Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated eq instances from scope #2830

Merged
merged 1 commit into from
May 25, 2019

Conversation

kailuowang
Copy link
Contributor

@kailuowang kailuowang commented May 4, 2019

Since cats-laws already breaks bin compat, we no longer need these bin compat and deprecated methods in laws.discipline.eq any more. They were causing deprecation warning in the downstream.

@codecov-io
Copy link

Codecov Report

Merging #2830 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2830   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files         368      368           
  Lines        6933     6933           
  Branches      303      303           
=======================================
  Hits         6529     6529           
  Misses        404      404
Impacted Files Coverage Δ
laws/src/main/scala/cats/laws/discipline/Eq.scala 33.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 422c989...ec40f51. Read the comment docs.

@kailuowang kailuowang added this to the 2.0.0-RC1 milestone May 5, 2019
@rossabaker rossabaker merged commit d550879 into typelevel:master May 25, 2019
@kailuowang kailuowang modified the milestones: 2.0.0-RC1, 2.0.0-M2, 2.0.0-M3 Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants