Don't send Gitter notifications for fork builds #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point I set up Travis CI to build for my fork of Cats. An unfortunate consequence of this is that pushing to a branch in my fork triggers a Travis build that then sends a build notification to the Cats Gitter channel. This is a little annoying and looks bad when I am doing experimental changes that cause failed builds in my fork. Also it's a little embarrassing when the 2000+ people in the Cats Gitter channel can see that I'm breaking stuff. I've configured an environment variable in the `typelevel/cats` Travis build for the Gitter webhook URL. My understanding is that for forks this environment variable won't be present and Travis will just silently not send Gitter notifications. Admittedly, I'm not certain that this will work, but I don't think that it causes any harm to give it a try.
|
cc @barambani, as I just noticed that your fork also submits Gitter notifications :D |
Codecov Report
@@ Coverage Diff @@
## master #2691 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 365 365
Lines 6757 6757
Branches 286 286
=======================================
Hits 6428 6428
Misses 329 329Continue to review full report at Codecov.
|
LukaJCB
approved these changes
Jan 9, 2019
|
We've got some approvals; let's give it a spin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point I set up Travis CI to build for my fork of Cats. An
unfortunate consequence of this is that pushing to a branch in my fork
triggers a Travis build that then sends a build notification to the Cats
Gitter channel. This is a little annoying and looks bad when I am doing
experimental changes that cause failed builds in my fork. Also it's a
little embarrassing when the 2000+ people in the Cats Gitter channel can
see that I'm breaking stuff.
I've configured an environment variable in the
typelevel/catsTravisbuild for the Gitter webhook URL. My understanding is that for forks
this environment variable won't be present and Travis will just silently
not send Gitter notifications. Admittedly, I'm not certain that this
will work, but I don't think that it causes any harm to give it a try.
Thank you for contributing to Cats!
This is a kind reminder to run
sbt prePRand commit the changed files, if any, before submitting.