Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type signature of productL in cats glossary #2625

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Fix type signature of productL in cats glossary #2625

merged 1 commit into from
Dec 3, 2018

Conversation

mtomko
Copy link
Contributor

@mtomko mtomko commented Nov 20, 2018

Thank you for contributing to Cats!

This is a kind reminder to run sbt prePR and commit the changed files before submitting.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtomko
Copy link
Contributor Author

mtomko commented Nov 20, 2018

Oh, doh, I think I misunderstood the instructions about sbt prePR.

@mtomko
Copy link
Contributor Author

mtomko commented Nov 20, 2018

Just to confirm sbt prePR didn't appear to change any files, the reminder is only to be sure I committed the files I meant to change, right?

@kailuowang
Copy link
Contributor

@mtomko sorry the instruction wasn't clear. sbt prePR reformats the code and runs a couple of other checks. If your code already conforms to the format settings then it won't change anything. But if it did you would need to include those changes in the PR as well.

@mtomko
Copy link
Contributor Author

mtomko commented Nov 20, 2018

I mentioned some other possible changes to the nomenclature file in gitter, which I'm happy to add to this PR. I'll summarize them here. If you want me to add them let me know and I'll include them in separate commits:

First, in the signature for flatTap, it currently reads:
F[A] => (A => F[-]) => F[A], but it might be clearer written F[A] => (A => F[B]) => F[A].

Secondly, the word Constraints appears to be misspelled as "Constrains" in a few tables. If you'd rather keep things in separate PRs, or feel that the changes aren't important, that's fine with me, too.

@mtomko
Copy link
Contributor Author

mtomko commented Nov 20, 2018

Got it, thanks for the information!

@codecov-io
Copy link

Codecov Report

Merging #2625 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2625   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files         363      363           
  Lines        6704     6704           
  Branches      305      289   -16     
=======================================
  Hits         6377     6377           
  Misses        327      327

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9c2b9b...2fc75a4. Read the comment docs.

@mtomko
Copy link
Contributor Author

mtomko commented Nov 27, 2018

I made the other changes in a separate PR: #2642

@ceedubs ceedubs merged commit 2fc75a4 into typelevel:master Dec 3, 2018
@kailuowang kailuowang added this to the 1.6 milestone Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants