Issue 2608 - Ambiguous implicit values for Functor[Kleisli[F, A, ?]] #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2618 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 363 363
Lines 6693 6693
Branches 307 291 -16
=======================================
Hits 6370 6370
Misses 323 323
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Nov 17, 2018
|
👍 |
LukaJCB
approved these changes
Nov 18, 2018
|
Thanks so much :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2608 . @kailuowang I tried this other way to disambiguate the instance priority as Mima check passes on all the Scala versions (
+mimaReportBinaryIssues) so I assume the BC is ok.I'm happy to change it though, and do as you suggest if you think there will be problems.