Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the vals inside all 'Ops' style classes private #2617

Merged
merged 3 commits into from
Nov 18, 2018

Conversation

coltfred
Copy link
Contributor

@coltfred coltfred commented Nov 16, 2018

This PR is to make private all the values inside the Ops style classes. This came from #2613.

TODO

  • Add examples which show all the syntax still works.

@codecov-io
Copy link

codecov-io commented Nov 16, 2018

Codecov Report

Merging #2617 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2617      +/-   ##
==========================================
- Coverage   95.17%   95.14%   -0.03%     
==========================================
  Files         363      363              
  Lines        6693     6695       +2     
  Branches      307      291      -16     
==========================================
  Hits         6370     6370              
- Misses        323      325       +2
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Validated.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/ApplicativeError.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/monoid.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/applicative.scala 100% <ø> (ø) ⬆️
free/src/main/scala/cats/free/FreeT.scala 90.66% <ø> (ø) ⬆️
core/src/main/scala/cats/data/Const.scala 100% <ø> (ø) ⬆️
...src/main/scala/cats/syntax/unorderedFoldable.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/apply.scala 25% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/set.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/either.scala 99.26% <ø> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabae03...1e6c2f1. Read the comment docs.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@kailuowang kailuowang added this to the 1.5.0-RC1 milestone Nov 17, 2018
@kailuowang kailuowang added the bug label Nov 17, 2018
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants