Contributing guidelines link #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fmsbeekmans thanks! This is a welcome change, but I think that you accidentally included some unrelated |
|
Thanks! Would you separate out the distinct addition to a new PR? |
fmsbeekmans
force-pushed
the
contributing-guidelines-link
branch
from
4fd122a
to
603a561
Compare
|
@ceedubs rebased them out. |
|
@ceedubs @kailuowang Thanks for the feedback, I've done the formatting and created a PR #2579 |
Codecov Report
@@ Coverage Diff @@
## master #2576 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 361 361
Lines 6630 6630
Branches 289 283 -6
=======================================
Hits 6308 6308
Misses 322 322Continue to review full report at Codecov.
|
ceedubs
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the link to the code guidelines in
CONTRIBUTING.mdabsolute so that it works in both the github markdown viewer and form the website as discussed here https://gitter.im/typelevel/cats?at=5bccdbb8bbdc0b25057a0716.Consistent with the references to laws lawtesting.