Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give test more memory #2568

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Conversation

kailuowang
Copy link
Contributor

I noticed that the test is running in fork and was using the default java options.
This setting change shall boost it's max memory to 6GB, according to travis, we have 7.5 G on the machine.

@codecov-io
Copy link

Codecov Report

Merging #2568 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2568   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         361      361           
  Lines        6630     6630           
  Branches      289      289           
=======================================
  Hits         6308     6308           
  Misses        322      322

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 774fb51...1dd0d81. Read the comment docs.

@LukaJCB LukaJCB merged commit fcc0465 into typelevel:master Oct 19, 2018
@@ -34,6 +34,7 @@ lazy val commonSettings = Seq(
},
resolvers ++= Seq(Resolver.sonatypeRepo("releases"), Resolver.sonatypeRepo("snapshots")),
fork in test := true,
test / javaOptions := Seq("-Xmx6G"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6GB is the max that our Travis instances have, right? We probably need to leave a little extra memory room for non-Java heap memory consumption on the instance, don't we?

@ceedubs
Copy link
Contributor

ceedubs commented Oct 21, 2018

I see this warning when running tests locally: [warn] javaOptions will be ignored, fork is set to false

@kailuowang
Copy link
Contributor Author

The Travis machine we use has 7.5GB. So we have some room left.
The warning you got worth investigating. The fork in test is set to true right above...I am on my phone, will check later.

@ceedubs
Copy link
Contributor

ceedubs commented Oct 23, 2018

I've restarted a lot of builds that failed with OOM in the past couple of days. I don't know whether it's happening more often than before or not, but it's worth keeping an eye on.

@kailuowang kailuowang mentioned this pull request Oct 23, 2018
@kailuowang
Copy link
Contributor Author

kailuowang commented Oct 23, 2018

@ceedubs I finally got some time to correct the setting in #2580

@kailuowang kailuowang deleted the increase-test-memory branch October 23, 2018 02:57
@kailuowang kailuowang added this to the 1.5 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants