Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cats logo as svg and new "cats friendly" badge #2524

Merged
merged 1 commit into from
Sep 25, 2018
Merged

cats logo as svg and new "cats friendly" badge #2524

merged 1 commit into from
Sep 25, 2018

Conversation

TomTriple
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Sep 23, 2018

Codecov Report

Merging #2524 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2524   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files         358      358           
  Lines        6530     6530           
  Branches      282      282           
=======================================
  Hits         6227     6227           
  Misses        303      303

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d5a51a...bd5156b. Read the comment docs.

kailuowang
kailuowang previously approved these changes Sep 23, 2018
* add new "cats friendly" badge as svg image (#1807)

* add exported .png images of both also
@TomTriple
Copy link
Contributor Author

TravisCI gave me a "No output has been received in the last 10m0s" on Scala. 2.13... not sure why that happens. I triggered a rebuild again.

@kailuowang
Copy link
Contributor

kailuowang commented Sep 24, 2018

Thank so much! Once this is merged, we could update the README.md to provide it on the homepage.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

@rossabaker
Copy link
Member

What's the recommended way for projects to embed these? Copy them into our repos? Solemnly swear that we'll never change the URL?

@kailuowang
Copy link
Contributor

I think copy them to their own repos might be easier. do we need to specify the license of this and the Cats logo? or MIT is going to cover this?

@TomTriple
Copy link
Contributor Author

Embedding them with a link to our repo has the advantage that we can change it later and other have an always up-to-date version without any work on their side.

@kailuowang
Copy link
Contributor

Let's merge this and add links to the README

@kailuowang kailuowang merged commit f21196c into typelevel:master Sep 25, 2018
@kailuowang kailuowang added this to the 1.5 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants