Adding tests for binary compat that can't be tested by Mima #2509
Conversation
| @@ -216,10 +216,10 @@ lazy val docSettings = Seq( | |||
| includeFilter in Jekyll := (includeFilter in makeSite).value | |||
| ) | |||
|
|
|||
| def mimaSettings(moduleName: String) = { | |||
| def mimaPrevious(moduleName: String, scalaVer: String, ver: String): List[ModuleID] = { | |||
There was a problem hiding this comment.
Note for @rossabaker , no need to read these changes regarding change to mimaPreviousArtifacts change. For now I'm not using them and hard coded the two cats versions to test binary compat (1.2.0 and 1.3.0)
Update: No longer relevant.
kailuowang
changed the title
|
Turns out coursier needs be disabled for this test to work. (although I don't know the root cause) |
build.sbt
Outdated
| @@ -494,6 +502,25 @@ lazy val bench = project.dependsOn(macrosJVM, coreJVM, freeJVM, lawsJVM) | |||
| )) | |||
| .enablePlugins(JmhPlugin) | |||
|
|
|||
|
|
|||
| lazy val binCompactTest = project | |||
There was a problem hiding this comment.
Should this be binCompatTest (and also in the source folder)?
Codecov Report
@@ Coverage Diff @@
## master #2509 +/- ##
==========================================
- Coverage 95.38% 95.19% -0.19%
==========================================
Files 357 359 +2
Lines 6528 6541 +13
Branches 278 281 +3
==========================================
Hits 6227 6227
- Misses 301 314 +13
Continue to review full report at Codecov.
|
I am trying to add automated tests to test binary compatibility at places that we had to add mima exceptions. The idea is based off @rossabaker 's feedback here.
At the moment, I couldn't get the tests to work properly. It passes even when I introduced BC breaking changes.
@rossabaker since you created a similar test before, would you help spot where I got things wrong here?
Thanks so much!