Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chain docs #2505

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Add Chain docs #2505

merged 1 commit into from
Sep 25, 2018

Conversation

LukaJCB
Copy link
Member

@LukaJCB LukaJCB commented Sep 16, 2018

Some documentation for Chain. Partially adopted from the blog post I wrote recently, but with more detail and a short mention of NonEmptyChain as well.

Daenyth
Daenyth approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@Daenyth Daenyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

@kailuowang kailuowang added this to the 1.5 milestone Sep 19, 2018
easel
easel approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@easel easel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was wondering what this "Chain" was that I just saw appearing, so double win for me =p

@kailuowang
Copy link
Contributor

thank you @easel and @Daenyth for the review, really helpful.

@LukaJCB LukaJCB merged commit 04e8fcf into typelevel:master Sep 25, 2018
@LukaJCB LukaJCB deleted the chain-docs branch September 25, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daenyth Daenyth Daenyth approved these changes

@kailuowang kailuowang kailuowang approved these changes

@easel easel easel approved these changes

@rossabaker rossabaker rossabaker approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
1.5-RC0
Development

Successfully merging this pull request may close these issues.
5 participants
@LukaJCB @kailuowang @Daenyth @easel @rossabaker