Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill scala-collection-compat #2488

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

travisbrown
Copy link
Contributor

Are we sure we even need this? I just ran buildJVM on my laptop for 2.13.0-M4 and it worked just fine.

@kailuowang
Copy link
Contributor

Just went through the original PR adding M4 support, it is not needed indeed.
What happened was that there were a lot of deprecations in collections whose migration can't be cross compiled without scala-collection-compat. it turned out that even with scala-collections-compat it was still too much work, so we ended up disabling the deprecation warnings in 2.13-M4 build and roll back those changes. The dependency, however, was left alone.

Once build green I am going to merge this one and cherry-pick it back to 1.3.x branch and release a 1.3.2.
Thanks @travisbrown!

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@travisbrown
Copy link
Contributor Author

Thanks much @kailuowang, @LukaJCB!

@codecov-io
Copy link

codecov-io commented Sep 12, 2018

Codecov Report

Merging #2488 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2488   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files         357      357           
  Lines        6517     6517           
  Branches      279      282    +3     
=======================================
  Hits         6216     6216           
  Misses        301      301

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f285048...bfdbe01. Read the comment docs.

@kailuowang kailuowang merged commit c138c01 into typelevel:master Sep 12, 2018
@kailuowang kailuowang added this to the 1.4 milestone Sep 12, 2018
@kailuowang kailuowang added the bug label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants