Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unit from Applicative #2246

Merged
merged 1 commit into from
May 5, 2018
Merged

Conversation

johnynek
Copy link
Contributor

@johnynek johnynek commented May 5, 2018

We have a unit on Applicative, but we weren't using it in a few places where we could.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented May 5, 2018

Codecov Report

Merging #2246 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2246   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files         333      333           
  Lines        5787     5787           
  Branches      222      218    -4     
=======================================
  Hits         5495     5495           
  Misses        292      292
Impacted Files Coverage Δ
core/src/main/scala/cats/Alternative.scala 88.88% <100%> (ø) ⬆️
core/src/main/scala/cats/Applicative.scala 95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba9a59...85f2a46. Read the comment docs.

@kailuowang kailuowang merged commit b163e77 into typelevel:master May 5, 2018
@kailuowang kailuowang added this to the 1.2 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants