Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valueOrF to EitherT #2192

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Add valueOrF to EitherT #2192

merged 1 commit into from
Mar 14, 2018

Conversation

denisrosca
Copy link
Contributor

@denisrosca denisrosca commented Mar 14, 2018

In certain circumstances the default value might be wrapped in the F[_] context already. I think valueOrF belongs in EitherT.

@codecov-io
Copy link

codecov-io commented Mar 14, 2018

Codecov Report

Merging #2192 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2192      +/-   ##
==========================================
+ Coverage   94.73%   94.73%   +<.01%     
==========================================
  Files         330      330              
  Lines        5582     5585       +3     
  Branches      209      209              
==========================================
+ Hits         5288     5291       +3     
  Misses        294      294
Impacted Files Coverage Δ
core/src/main/scala/cats/data/EitherT.scala 97.65% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3a12ef...e8a0d85. Read the comment docs.

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, and it mirrors nicely with getOrElseF.

@kailuowang kailuowang added this to the 1.1 milestone Mar 14, 2018
@kailuowang kailuowang merged commit f644982 into typelevel:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants