added liftTo to Try, Either and Option
#2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailuowang
changed the title
liftTo to Try Either and OptionliftTo to Try, Either and Option
Codecov Report
@@ Coverage Diff @@
## master #2179 +/- ##
==========================================
+ Coverage 94.71% 94.75% +0.04%
==========================================
Files 329 330 +1
Lines 5558 5568 +10
Branches 215 201 -14
==========================================
+ Hits 5264 5276 +12
+ Misses 294 292 -2
Continue to review full report at Codecov.
|
tpolecat
approved these changes
Mar 2, 2018
| * res1: scala.Either[String, Int] = Left(Empty) | ||
| * }}} | ||
| */ | ||
| def liftTo[F[_]]: LiftToPartiallyApplied[F, A] = new LiftToPartiallyApplied(oa) |
There was a problem hiding this comment.
I'm surprised this works because LiftToPartiallyApplied is marked private[cats] … I guess I can have a value of this type but I can't declare or ascribe it. Interesting trick.
There was a problem hiding this comment.
this is the fun of working with scala.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple syntax extensions