Update deprecations to product{L,R} instead of ap{L,R} #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so when you look at the `Applicative` scaladoc you don't have a bunch of `ap3`, `ap4`, etc noise mixed in with the more meaningful methods. Instead, the generated higher-arity methods show up in separate scaladoc groups below. To see the changes you can pull this branch, run `sbt unidoc` (you may need to clean first), and open `cats/docs/target/scala-2.12/unidoc/cats/Applicative.html` in your browser.
* Draft release notes * Update * Update * Update * Update * Update * Update Authors * Update * Update * Update * Update * update * Update * Update CHANGES.md * Update AUTHORS.md * Update README.md
Add grouping to scaladoc for arity methods
kailuowang
approved these changes
Dec 19, 2017
|
oops. |
LukaJCB
approved these changes
Dec 19, 2017
|
I asked on cats-dev, should this have targeted the 1.0 branch? |
|
Retarget to 1.0 pulled in other things already on cats master. Will cherry-pick and force-push. |
|
Never mind the cherry-pick-and-push-f. Discussed on cats-dev, and we want all these master changes back on 1.0 anyway. |
Codecov Report
@@ Coverage Diff @@
## 1.0 #2121 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 328 328
Lines 5533 5533
Branches 199 199
=======================================
Hits 5238 5238
Misses 295 295
Continue to review full report at Codecov.
|
kailuowang
added a commit
that referenced
this pull request
Feb 2, 2018
* Setting version to 1.0.0-RC2
* Setting version to 1.0.0-SNAPSHOT
* Update deprecations to product{L,R} instead of ap{L,R} (#2121)
* Add grouping to scaladoc for arity methods
This makes it so when you look at the `Applicative` scaladoc you don't
have a bunch of `ap3`, `ap4`, etc noise mixed in with the more
meaningful methods. Instead, the generated higher-arity methods show up
in separate scaladoc groups below.
To see the changes you can pull this branch, run `sbt unidoc` (you may
need to clean first), and open
`cats/docs/target/scala-2.12/unidoc/cats/Applicative.html` in your
browser.
* Add doctest examples for Apply (#2086)
* Get ready for RC2 (#2044)
* Draft release notes
* Update
* Update
* Update
* Update
* Update
* Update Authors
* Update
* Update
* Update
* Update
* update
* Update
* Update CHANGES.md
* Update AUTHORS.md
* Update README.md
* Update deprecations to product{L,R} instead of ap{L,R}
* Setting version to 1.0.0
* Setting version to 1.0.1-SNAPSHOT
* Setting version to 1.0.1
* Setting version to 1.0.2-SNAPSHOT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.