Add comparison method in Order companion object #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main goal of this PR was to add syntax for the `Order` and `PartialOrder` syntax (provided via machinist ops) to address [this comment](typelevel#1867 (comment)). In the process I noticed that the Order companion object didn't have a `comparison` function to forward through to the type class instance like it did for other methods, so I added that. I did notice that the `Order`/`PartialOrder` syntax does work whether or not you take the `Order`/`PartialOrder` instances as implicit parameters to the ops classes. I think that only @non understands quite what's going on with the machinist syntax macros, so I didn't make the changes to take away those implicit parameters without knowing the implications. The tests pass either way, so I think that end-code should work for users either way.
|
Tests passed locally, but during the build one failed with I'll come up with a workaround. |
Codecov Report
@@ Coverage Diff @@
## master #2100 +/- ##
==========================================
+ Coverage 94.66% 94.79% +0.13%
==========================================
Files 322 322
Lines 5451 5455 +4
Branches 215 216 +1
==========================================
+ Hits 5160 5171 +11
+ Misses 291 284 -7
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Dec 17, 2017
johnynek
approved these changes
Dec 17, 2017
LukaJCB
approved these changes
Dec 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR was to add syntax tests for the
OrderandPartialOrdersyntax (provided via machinist ops) to address this comment.In the process I noticed that the Order companion object didn't have a
comparisonfunction to forward through to the type class instance likeit did for other methods, so I added that.
I did notice that the
Order/PartialOrdersyntax does work whether ornot you take the
Order/PartialOrderinstances as implicit parametersto the ops classes. I think that only @non understands quite what's
going on with the machinist syntax macros, so I didn't make the changes
to take away those implicit parameters without knowing the implications.
The tests pass either way, so I think that end-code should work for
users either way.