Update guidelines.md with implicit priority #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaJCB
approved these changes
Dec 11, 2017
Codecov Report
@@ Coverage Diff @@
## master #2095 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 318 318
Lines 5410 5410
Branches 210 210
=======================================
Hits 5121 5121
Misses 289 289Continue to review full report at Codecov.
|
ceedubs
approved these changes
Dec 12, 2017
| } | ||
|
|
||
| abstract class KleisliInstance1 { | ||
| implicit def catsDataFunctorForKleisli[F[_], A]: Functor[Kleisli[F, A, ?]] = ... |
There was a problem hiding this comment.
It's really outside of the point of this example, but my mental compiler complained that you would need F[_]:Monad and F[_]:Functor constraints to be able to implement them :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.