Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restruct functor #1934

Merged
merged 3 commits into from
Oct 2, 2017
Merged

Restruct functor #1934

merged 3 commits into from
Oct 2, 2017

Conversation

kailuowang
Copy link
Contributor

Big but rather mechanical changes according to #1930

  1. Move Profunctor and Strong to the arrow package
  2. Move Bifunctor, Invariant and Contravariant to root package

@codecov-io
Copy link

codecov-io commented Sep 26, 2017

Codecov Report

Merging #1934 into master will increase coverage by 0.02%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1934      +/-   ##
==========================================
+ Coverage   95.55%   95.57%   +0.02%     
==========================================
  Files         248      248              
  Lines        4430     4454      +24     
  Branches      116      110       -6     
==========================================
+ Hits         4233     4257      +24     
  Misses        197      197
Impacted Files Coverage Δ
laws/src/main/scala/cats/laws/BifunctorLaws.scala 100% <ø> (ø) ⬆️
...in/scala/cats/laws/discipline/CartesianTests.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/arrow/Profunctor.scala 100% <ø> (ø)
core/src/main/scala/cats/data/Validated.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/data/Func.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/Bitraverse.scala 80% <ø> (ø) ⬆️
core/src/main/scala/cats/data/Nested.scala 100% <ø> (ø) ⬆️
...e/src/main/scala/cats/ContravariantCartesian.scala 66.66% <ø> (ø) ⬆️
core/src/main/scala/cats/instances/function.scala 100% <ø> (ø) ⬆️
...in/scala/cats/laws/discipline/BifunctorTests.scala 100% <ø> (ø) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8637d...1af9387. Read the comment docs.

@@ -1,9 +1,8 @@
package cats.tests

import cats._
import cats.{Contravariant, _}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member

@tpolecat tpolecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kailuowang kailuowang merged commit 0997f43 into typelevel:master Oct 2, 2017
@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants