Fixing Eq[Function1] in testsJS; break JS build to separate matrix build.
#1671
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1671 +/- ##
==========================================
+ Coverage 93.38% 93.43% +0.04%
==========================================
Files 241 241
Lines 4054 4068 +14
Branches 134 140 +6
==========================================
+ Hits 3786 3801 +15
+ Misses 268 267 -1
Continue to review full report at Codecov.
|
kailuowang
changed the title
Eq[Function1] in testsJS; break JS build to separate matrix build.
There was a problem hiding this comment.
Thanks @kailuowang! One minor question about a blank test class, but otherwise this looks great to me.
| @@ -0,0 +1,5 @@ | |||
| package cats.laws.discipline | |||
There was a problem hiding this comment.
Oops that's an accident. Will remove after I get to a computer
scripts/travis-publish.sh
Outdated
| @@ -20,18 +20,24 @@ export publish_cmd="publishLocal" | |||
| if [[ $TRAVIS_PULL_REQUEST == "false" && $TRAVIS_BRANCH == "master" && $(cat version.sbt) =~ "-SNAPSHOT" ]]; then | |||
| export publish_cmd="publish gitSnapshots publish" | |||
| # temporarily disable to stabilize travis | |||
| #if [[ $TRAVIS_SCALA_VERSION = "2.11.8" ]]; then | |||
| # export publish_cmd="$publish_cmd ghpagesPushSite" | |||
| #if [[ $TRAVIS_SCALA_VERSION = "2.11.11" ]]; then | |||
There was a problem hiding this comment.
Kind of tangential to this PR, and it looks like the code is commented out anyway, but we may want to change this to something like if [[ $TRAVIS_SCALA_VERSION =~ ^2\.11\. ]]. My knowledge on bash regular expressions is a bit foggy, so this may not be quite right.
There was a problem hiding this comment.
I verified that the code works.
|
@ceedubs feedback addressed. |
|
Thanks @kailuowang! This looks good to me -- just waiting for the build to finish. It looks like we are only using 1 worker in the scalatest/scalacheck configuration. Do you remember whether we've tried to increase that to reduce build times? |
I don't, but maybe @BennyHill does? |
|
From memory: On scala.js, you only have one thread, so setting more workers will have no difference. On jvm, it may help, if you have lots of threads. But sbt tends to grab lots of threads first, and besides, on Travis-CI we do not have many threads to start with - and I believe we run tests in a separate JVM as well So it still might be worth looking, but I would rather spend my time elsewhere |
|
@BennyHill thanks for the input. Since it's really easy to try bumping the number of workers, I'll give it a try in a PR once this one is merged, but I won't get my hopes up :) |
This PR breaks out the scalajs builds to separate travis matrix build to cut down build time which was exceeding the 50 minute hard limit set by traivs.
see #1666 for further discussion.