Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add groupBy to NonEmptyList and groupByNel to List syntax #1580

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

julien-truffaut
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 30, 2017

Codecov Report

Merging #1580 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1580      +/-   ##
==========================================
+ Coverage   92.34%   92.36%   +0.01%     
==========================================
  Files         247      247              
  Lines        3907     3916       +9     
  Branches      136      132       -4     
==========================================
+ Hits         3608     3617       +9     
  Misses        299      299
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/list.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/data/NonEmptyList.scala 98.94% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ebdbbd...f2d39c7. Read the comment docs.

@kailuowang
Copy link
Contributor

👍 LGTM

@ceedubs
Copy link
Contributor

ceedubs commented Mar 30, 2017

👍 love it.

@kailuowang kailuowang merged commit 082563a into master Mar 30, 2017
@kailuowang kailuowang deleted the nel-groupBy branch March 30, 2017 15:49
@kailuowang kailuowang modified the milestone: 1.0.0-MF Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants