Fix mistake in documentation of Group.remove #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation initially said `remove` was equivalent to `combine(a, inverse(a))`. Changed to be equivalent to `combine(a, inverse(b))` instead.
Codecov Report
@@ Coverage Diff @@
## master #1566 +/- ##
=======================================
Coverage 92.34% 92.34%
=======================================
Files 247 247
Lines 3904 3904
Branches 131 131
=======================================
Hits 3605 3605
Misses 299 299
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation initially said
removewas equivalent tocombine(a, inverse(a)). Changed to be equivalent tocombine(a, inverse(b))instead.