Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make catchNonFatal on Future async #1510

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Make catchNonFatal on Future async #1510

merged 1 commit into from
Jan 3, 2017

Conversation

johnynek
Copy link
Contributor

@johnynek johnynek commented Jan 2, 2017

closes #1482

This was referenced Jan 2, 2017
Closed
Closed
@codecov-io
Copy link

codecov-io commented Jan 2, 2017 •
edited
Loading

Current coverage is 92.05% (diff: 0.00%)

Merging #1510 into master will decrease coverage by 0.01%

@@             master      #1510   diff @@
==========================================
  Files           246        246          
  Lines          3686       3715    +29   
  Methods        3567       3594    +27   
  Messages          0          0          
  Branches        119        121     +2   
==========================================
+ Hits           3394       3420    +26   
- Misses          292        295     +3   
  Partials          0          0

Powered by Codecov. Last update a6efd9d...4c759b6

kailuowang
kailuowang approved these changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍

@travisbrown
Copy link
Contributor

I think this is reasonable, but the docs for catchNonFatal should probably be changed not to mention pure.

Here we try to call pure or catch and raise.

@non
Copy link
Contributor

non commented Jan 3, 2017

👍 with or without doc change

@johnynek johnynek merged commit 86ee0ac into master Jan 3, 2017
@johnynek johnynek deleted the oscar/future-clean branch January 3, 2017 22:59
@stew stew removed the in progress label Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add abilitity to instantiate a non-blocking Future from MonadError
6 participants
@johnynek @codecov-io @travisbrown @non @kailuowang @stew