make stack-safety-test for tailRecM in MonadTests only fail when checking the test #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king the test Previously, already calling 'MonadTests[Signal].monad[Int, Int, Int].all' would cause a StackOverflowError, now this is only caused when executing the test and can be captured e.g. by using check. In our case, this solved a ScalaTest test suite from aborting and thus not executing any tests to just a failing test.
|
👍 on travis green |
|
👍 |
Current coverage is 92.07% (diff: 100%)@@ master #1507 diff @@
==========================================
Files 246 246
Lines 3659 3659
Methods 3534 3539 +5
Messages 0 0
Branches 125 120 -5
==========================================
Hits 3369 3369
Misses 290 290
Partials 0 0
|
|
thanks for the quick merge! can we backport this to 0.8 or somehow otherwise make some release which includes this soonishly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, already calling
MonadTests[Signal].monad[Int, Int, Int].allwould cause a StackOverflowError, now this is only caused when executing the test and can be captured e.g. by usingcheck.In our case, this solved a ScalaTest test suite from aborting and thus not executing any tests to just a failing test.