Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagram of typeclass hierarchy continue #822 #1416

Merged
merged 5 commits into from
Oct 25, 2016

Conversation

kailuowang
Copy link
Contributor

Obviously this is just a start, we can improve it once we have a starting point.

@kailuowang kailuowang added this to the 0.8.0 milestone Oct 21, 2016
@kailuowang
Copy link
Contributor Author

diagram result
687474703a2f2f672e67726176697a6f2e636f6d2f673f253041253230253230646967726170682532304725323025374225304125323025323025323025323061697a652532303d253232342c342532323b253041253230253230253230253230656467652532302535426469723d6261636b2535442530

@kailuowang kailuowang mentioned this pull request Oct 21, 2016
6 tasks
@codecov-io
Copy link

codecov-io commented Oct 21, 2016

Current coverage is 91.68% (diff: 100%)

Merging #1416 into master will not change coverage

@@             master      #1416   diff @@
==========================================
  Files           240        240          
  Lines          3608       3608          
  Methods        3540       3540          
  Messages          0          0          
  Branches         67         67          
==========================================
  Hits           3308       3308          
  Misses          300        300          
  Partials          0          0          

Powered by Codecov. Last update fe026bc...4b48528

@ghost
Copy link

ghost commented Oct 22, 2016

Just in case it's been forgotten - @non's prior art:

http://plastic-idolatry.com/erik/cats-graph.png

http://plastic-idolatry.com/erik/cats-graph2.png

@kailuowang
Copy link
Contributor Author

Didn't forget that but I like this one because it's text specified and thus easy to change.

@adelbertc
Copy link
Contributor

👍

@travisbrown
Copy link
Contributor

👍, this looks great. I don't know anything about Gravizo—I don't suppose it's practical to have this rendered locally during the build?

@travisbrown travisbrown mentioned this pull request Oct 25, 2016
13 tasks
@kailuowang
Copy link
Contributor Author

@travisbrown the image is generated on Gravizo server and displays in the viewer - in most cases, the browser. Merging with 2 thumbs up.

@kailuowang kailuowang merged commit 0f70acf into typelevel:master Oct 25, 2016
@travisbrown
Copy link
Contributor

@kailuowang Right—I was just wondering if it would be possible to do without relying on a third-party (commercial) service, since it looks like the service is just running graphviz for you. I'm happy to see this merged as-is, though.

@kailuowang
Copy link
Contributor Author

I see. Not familiar with it myself (I merely resurrect @rklaehn's PR). Upon some research there are quite a few tools that can render dot locally. For example, https://github.com/drdozer/graphviz-s/tree/102215679c7da01689d3e4aade5f38782dbdb142. It might take some work to integrate it with sbt (this lib is 2.11). I agree it's less optimal to rely on a 3rd party commercial service.

@kailuowang kailuowang deleted the rklaehn-feature/classdiagram branch October 25, 2016 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants