Scala 2.12.0-RC2 #1415

travisbrown · 2016-10-20T18:34:39Z

This PR includes @BennyHill's changes from #1382 together with some more recent version updates and two other things:

I've updated SBT to 0.13.13-RC3 and fixed the deprecated operators.
I've changed the docs for Either to explain the difference in flatMap between 2.12 and the syntax provided by Cats for 2.10 and 2.11. I've also changed the tut shed that was failing the build (because it no longer failed to compile on 2.12) to an ordinary scala shed.

In addition to the usual review, here's what I see that still needs to be done:

Publish a new version of catalysts and remove the -SNAPSHOT here. I've got a PR open for this that I think is ready to go.
Decide what to do about bench. Right now it's just not included in the build, so that you have to run something like sbt bench/test if you want to confirm that it's not broken. We could use sbt-doge, or we could have some stuff in the Travis CI build to run that command on 2.10 and 2.11 only, or we could just leave it and wait for sbt-jmh to be updated for 2.12. Given that we don't publish bench and that it doesn't have any tests, my vote would be just to wait.
See about changing fork in test back to true. I'm not sure why it was changed in Add scala 2.12.0-RC1 #1382, but it seems fine to me to change it back. @BennyHill, can you confirm?
Have someone who's more familiar with the Travis CI setup confirm that there's nothing else that needs to be done.

codecov-io · 2016-10-21T16:35:19Z

Current coverage is 92.16% (diff: 100%)

Merging #1415 into master will increase coverage by 0.48%

@@             master      #1415   diff @@
==========================================
  Files           240        240          
  Lines          3617       3573    -44   
  Methods        3555       3510    -45   
  Messages          0          0          
  Branches         61         63     +2   
==========================================
- Hits           3316       3293    -23   
+ Misses          301        280    -21   
  Partials          0          0

Powered by Codecov. Last update f90245d...d5734c3

ghost · 2016-10-22T11:00:54Z

See about changing fork in test back to true

The clue is the original kept as a comment... so for sure it was an oversight and should be reverted if possible

ghost · 2016-10-22T11:02:59Z

.travis.yml

- 2.11.8
+  - 2.10.6
+  - 2.11.8
+  - 2.12.0-RC2


delete this line as it should be in the matrix

ghost · 2016-10-22T11:03:23Z

.travis.yml

+
+matrix:
+  include:
+  - scala: 2.12.0-RC1


And change this to RC2

ghost · 2016-10-22T11:09:35Z

For bench, see this sbt/sbt-jmh#89 issue

ghost · 2016-10-22T11:13:43Z

https://issues.scala-lang.org/browse/SI-9923 notes that the "Unused import" warning is fixed in paradise_2.12.0-RC2 so we should remove the fix setttings and methods from the build

ghost · 2016-10-22T11:15:57Z

for https://issues.scala-lang.org/browse/SI-9931 we should action @SethTisue 's final comment:

I would suggest you comment your fix, with a link to this ticket, as it isn't obvious why the type annotations would be necessary. Otherwise it seems fine to me. Except that perhaps you might prefer the "val c = d" style fix from my comment above?

ghost · 2016-10-22T11:17:38Z

I'll look at the catalysts PR later today,

ktoso · 2016-10-22T11:21:44Z

project/plugins.sbt

 addSbtPlugin("com.typesafe.sbt"     % "sbt-ghpages"           % "0.5.3")
-addSbtPlugin("pl.project13.scala"   % "sbt-jmh"               % "0.2.11")
+addSbtPlugin("pl.project13.scala"   % "sbt-jmh"               % "0.2.12")


Update to 0.2.16 and it'll "just work"™, no need to additional release of the plugin for it to work with 2.12

ktoso · 2016-10-22T11:23:24Z

Hi there @travisbrown @BennyHill,
feel free to ping me directly on anything related sbt-jmh - happy to help 👍

In this specific case you just need to upgrade to 0.2.16 and it'll just work.
The plugin still uses "old scala" which is fine, because that's what sbt uses, and the extras library is scala version independent (pure java), so no need for cross releasing anything for 2.12 (I confirmed this by running a benchmark on 2.12.0-RC2 right now).

Happy hakking :)

ghost · 2016-10-22T11:29:00Z

Thanks @ktoso ! I think what has happened is that I pushed an early PR for 2.12-0-RC1 that had quite a few "hacks" to just get it to compile so that others could see what was what - and I think that was about the same time that you released the new jmh.

But I think we are getting there... 😸

ktoso · 2016-10-22T11:30:07Z

👍
Looking forward to cats for 2.12.0-RC2, thanks for working on it! :-)

travisbrown · 2016-10-22T15:53:04Z

Thanks, @BennyHill! I've added a comment about SI-9931, re-enabled fatal warnings and forking in tests, added bench back, and fixed the Travis CI versions. Now I think we're just waiting on Catalysts.

travisbrown · 2016-10-22T16:34:16Z

Thanks, @ktoso—everything looks fine with 0.2.16!

travisbrown · 2016-10-23T18:17:51Z

Okay, just pushed the catalyst update (thanks, @BennyHill). Once this succeeds I'll rebase the branch to get rid of the merge commits and then I think it'll be ready for any last review and merging.

travisbrown · 2016-10-23T20:29:20Z

Okay, tests are passing and I've just rebased, so this is ready for merging after review.

adelbertc · 2016-10-23T21:41:09Z

LGTM! Thanks so much @travisbrown 👍

ghost · 2016-10-23T21:56:33Z

build.sbt

-  }
+  coverageMinimum := 60,
+  coverageFailOnMinimum := false,
+  coverageHighlighting := scalaBinaryVersion.value != "2.10"


As per gitter, I would expect that this is no longer required

ghost · 2016-10-23T22:02:21Z

I think there is a missing .configure(disableScoverage210Jvm) in laws

travisbrown · 2016-10-23T22:34:20Z

Thanks, @BennyHill—you're right, I misunderstood what was temporary vs. permanent there. I've added back that line and it's passing locally.

johnynek · 2016-10-24T19:55:20Z

👍

non · 2016-10-24T19:59:59Z

Great work! Thanks @travisbrown and @BennyHill! 👍

ktoso · 2016-10-25T10:28:29Z

Great, cheers!

travisbrown added the in progress label Oct 20, 2016

SethTisue mentioned this pull request Oct 20, 2016

Maven build for 2.12 #1285

Closed

travisbrown mentioned this pull request Oct 20, 2016

0.8.0 time! #1412

Merged

13 tasks

ghost reviewed Oct 22, 2016

View reviewed changes

.travis.yml

- 2.11.8

- 2.10.6

- 2.11.8

- 2.12.0-RC2

Copy link

ghost Oct 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this line as it should be in the matrix

ghost reviewed Oct 22, 2016

View reviewed changes

.travis.yml

matrix:

include:

- scala: 2.12.0-RC1

Copy link

ghost Oct 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And change this to RC2

ktoso reviewed Oct 22, 2016

View reviewed changes

travisbrown mentioned this pull request Oct 22, 2016

Add scala 2.12.0-RC1 #1382

Closed

Alistair-Johnson and others added 11 commits October 23, 2016 15:09

Add scala 2.12.0-RC1

d20f50a

Fix tut on 2.12.0-RC1

b82418d

Updated new 2.12 deps

8a4f4bd

Update Scala, etc.

b0afe14

Remove local Scoverage publishing

601b523

Fix SBT warnings

5945b9b

Update Travis CI for Scala 2.12.0-RC2

36e1eaa

Update Either docs for 2.12, noting inconsistency

765f4c9

Exclude bench from default build

9a630ca

Fix Scala versions in Travis CI config

b347bf0

Turn JVM forking back on for tests

9d7d6cc

travisbrown added 8 commits October 23, 2016 15:11

Update sbt-jmh and add bench back to build

2839a5d

Ensure we get the right Tut version

b377bcc

Re-enable fatal warnings for 2.12

2aa10f1

Add note about SI-9931

56e0110

Avoid deprecated PropertyCheckConfig

b1e6a99

Update to catalysts 0.0.4 release

eda475f

Update sbt-microsites and remove explicit Tut dependency

a139801

Reinstate no coverage highlighting on 2.10

4c6fad8

travisbrown force-pushed the update/2.12.0-RC2 branch from 13547bc to 4c6fad8 Compare October 23, 2016 20:28

travisbrown changed the title ~~Scala 2.12.0-RC2 (do not merge)~~ Scala 2.12.0-RC2 Oct 23, 2016

ghost reviewed Oct 23, 2016

View reviewed changes

Disable Scoverage on Scala 2.10 for cats-laws

d5734c3

This was referenced Oct 24, 2016

Publish artifacts for Scala 2.12 circe/circe#302

Closed

Eval compile error in 2.12.0-RC1: Improvement or regression? #1377

Closed

adelbertc mentioned this pull request Oct 24, 2016

Add typelevel/cats to build scala/community-build#363

Closed

adelbertc merged commit a08b381 into typelevel:master Oct 25, 2016

stew removed the in progress label Oct 25, 2016

travisbrown mentioned this pull request Oct 25, 2016

Add stackUnsafeMonad to MonadTests #1417

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scala 2.12.0-RC2 #1415

Scala 2.12.0-RC2 #1415

travisbrown commented Oct 20, 2016 •

edited

Loading

codecov-io commented Oct 21, 2016 •

edited

Loading

ghost commented Oct 22, 2016

ghost Oct 22, 2016

ghost Oct 22, 2016

ghost commented Oct 22, 2016

ghost commented Oct 22, 2016

ghost commented Oct 22, 2016

ghost commented Oct 22, 2016

ktoso Oct 22, 2016

ktoso commented Oct 22, 2016 •

edited

Loading

ghost commented Oct 22, 2016

ktoso commented Oct 22, 2016

travisbrown commented Oct 22, 2016

travisbrown commented Oct 22, 2016

travisbrown commented Oct 23, 2016

travisbrown commented Oct 23, 2016

adelbertc commented Oct 23, 2016

ghost Oct 23, 2016

ghost commented Oct 23, 2016

travisbrown commented Oct 23, 2016

johnynek commented Oct 24, 2016

non commented Oct 24, 2016

ktoso commented Oct 25, 2016

Scala 2.12.0-RC2 #1415

Scala 2.12.0-RC2 #1415

Conversation

travisbrown commented Oct 20, 2016 • edited Loading

codecov-io commented Oct 21, 2016 • edited Loading

Current coverage is 92.16% (diff: 100%)

ghost commented Oct 22, 2016

ghost Oct 22, 2016

Choose a reason for hiding this comment

ghost Oct 22, 2016

Choose a reason for hiding this comment

ghost commented Oct 22, 2016

ghost commented Oct 22, 2016

ghost commented Oct 22, 2016

ghost commented Oct 22, 2016

ktoso Oct 22, 2016

Choose a reason for hiding this comment

ktoso commented Oct 22, 2016 • edited Loading

ghost commented Oct 22, 2016

ktoso commented Oct 22, 2016

travisbrown commented Oct 22, 2016

travisbrown commented Oct 22, 2016

travisbrown commented Oct 23, 2016

travisbrown commented Oct 23, 2016

adelbertc commented Oct 23, 2016

ghost Oct 23, 2016

Choose a reason for hiding this comment

ghost commented Oct 23, 2016

travisbrown commented Oct 23, 2016

johnynek commented Oct 24, 2016

non commented Oct 24, 2016

ktoso commented Oct 25, 2016

travisbrown commented Oct 20, 2016 •

edited

Loading

codecov-io commented Oct 21, 2016 •

edited

Loading

ktoso commented Oct 22, 2016 •

edited

Loading