Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ScalaCheck to 1.13.1, and fix the fallout. #1345

Merged
merged 9 commits into from
Sep 18, 2016

Commits on Sep 6, 2016

  1. Bump ScalaCheck to 1.13.1, and fix the fallout.

    This commit gets all our law tests working with a new, more robust
    ScalaCheck version. It currently relies upon an unreleased Discipline
    snapshot, so it definitely won't build in Travis.
    
    There were a bunch of test bugs that got fixed, mostly around
    foldRight/reduceRight consistency for non-empty data structures.
    
    One law violation was uncovered: MonadCombine[Option] doesn't pass the
    left-distributivity law we wrote. We should figure out whether this
    represents a real law violation and remove the instance, or whether
    the law is too strict somehow.
    
    One counter-example is:
    
        def f(x: Int): Option[Int] = if (x == 0) None else Some(x)
        val a = Option(0)
        val b = Option(1)
        (a <+> b).flatMap(f) != (a.flatMap(f) <+> b.flatMap(f))
    
    Review by @adelbertc et al. We will need to wait for a new Discipline
    release before merging this, and we'll need to do something about the
    MonadCombine laws/instances (currently the MonadCombine[Option] test
    is commented out).
    erik-stripe committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    dc032a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d6a9e02 View commit details
    Browse the repository at this point in the history
  3. Fix JS tests.

    erik-stripe committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    64b297e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4dcafc1 View commit details
    Browse the repository at this point in the history
  5. Fix scalacheck dependency error

    durban authored and erik-stripe committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    80a63f9 View commit details
    Browse the repository at this point in the history
  6. Remove left-distributivity law from MonadCombine.

    Also remove various obsolete/commented code.
    erik-stripe committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    742e1d2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9f45fe9 View commit details
    Browse the repository at this point in the history
  8. Appease ScalaStyle.

    erik-stripe committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    1732ec1 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2016

  1. Comment orphan Cogen instances.

    We provide some Cogen instances which were not included with 1.13.2.
    These instances will be provided in a future release, so when they
    become available we should remove ours.
    
    This commit also removes one instance that wasn't in 1.13.1 but was
    available in 1.13.2: Cogen[Stream[A]].
    erik-stripe committed Sep 8, 2016
    Configuration menu
    Copy the full SHA
    91fdbbf View commit details
    Browse the repository at this point in the history