-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ScalaCheck to 1.13.1, and fix the fallout. #1345
Merged
Merged
Commits on Sep 6, 2016
-
Bump ScalaCheck to 1.13.1, and fix the fallout.
This commit gets all our law tests working with a new, more robust ScalaCheck version. It currently relies upon an unreleased Discipline snapshot, so it definitely won't build in Travis. There were a bunch of test bugs that got fixed, mostly around foldRight/reduceRight consistency for non-empty data structures. One law violation was uncovered: MonadCombine[Option] doesn't pass the left-distributivity law we wrote. We should figure out whether this represents a real law violation and remove the instance, or whether the law is too strict somehow. One counter-example is: def f(x: Int): Option[Int] = if (x == 0) None else Some(x) val a = Option(0) val b = Option(1) (a <+> b).flatMap(f) != (a.flatMap(f) <+> b.flatMap(f)) Review by @adelbertc et al. We will need to wait for a new Discipline release before merging this, and we'll need to do something about the MonadCombine laws/instances (currently the MonadCombine[Option] test is commented out).
Configuration menu - View commit details
-
Copy full SHA for dc032a9 - Browse repository at this point
Copy the full SHA dc032a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6a9e02 - Browse repository at this point
Copy the full SHA d6a9e02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64b297e - Browse repository at this point
Copy the full SHA 64b297eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dcafc1 - Browse repository at this point
Copy the full SHA 4dcafc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80a63f9 - Browse repository at this point
Copy the full SHA 80a63f9View commit details -
Remove left-distributivity law from MonadCombine.
Also remove various obsolete/commented code.
Configuration menu - View commit details
-
Copy full SHA for 742e1d2 - Browse repository at this point
Copy the full SHA 742e1d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f45fe9 - Browse repository at this point
Copy the full SHA 9f45fe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1732ec1 - Browse repository at this point
Copy the full SHA 1732ec1View commit details
Commits on Sep 8, 2016
-
Comment orphan Cogen instances.
We provide some Cogen instances which were not included with 1.13.2. These instances will be provided in a future release, so when they become available we should remove ours. This commit also removes one instance that wasn't in 1.13.1 but was available in 1.13.2: Cogen[Stream[A]].
Configuration menu - View commit details
-
Copy full SHA for 91fdbbf - Browse repository at this point
Copy the full SHA 91fdbbfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.