Some attribution work #1276
Some attribution work #1276
Conversation
This is inspired by typelevel#1275. It doesn't include a CLA, and there is most likely more work that should be done with respect to attribution, but I'm hoping that this is a step in the right direction. I've added a link to the scalaz contributors page within AUTHORS.md. I'm not sure who all out of that should and would want to be directly listed in the authors page for Cats. I've explicitly added Brian McKenna to the authors page, as my understanding of [this tweet](https://twitter.com/puffnfresh/status/762901748772057088) is that he would like to be on there.
|
👍 Thanks |
| @@ -98,6 +99,12 @@ possible: | |||
| * yilinwei | |||
| * Zach Abbott | |||
|
|
|||
| Cats has been heavily inspired by [scalaz](https://github.com/scalaz/scalaz), | |||
| and some Cats code is only a slightly modified version of code originating in | |||
| scalaz. Therefore, we'd also like to credit and thank all of the | |||
There was a problem hiding this comment.
This is nitpicky, but maybe capitalize "scalaz" throughout for consistency with "Cats" and other project names here, and with the Scalaz README?
There was a problem hiding this comment.
👍 thanks good catch. I tend to capitalize Cats to make it clear that I'm talking about the project and not the group of animals, but I definitely didn't mean to be inconsistent here.
|
I'm pretty sure that |
| @@ -98,6 +99,12 @@ possible: | |||
| * yilinwei | |||
| * Zach Abbott | |||
|
|
|||
| Cats has been heavily inspired by [scalaz](https://github.com/scalaz/scalaz), | |||
There was a problem hiding this comment.
Suggestion:
Cats has been inspired by many libraries, including Scalaz, Haskell's Prelude, and others. In particular, some Cats code is only…
To acknowledge stuff like witherable, etc.?
There was a problem hiding this comment.
👍 sorry I missed this when you first posted it.
|
Yes, here ... itself derived from an earlier uses of ambiguity to encode negation. |
|
As @milessabin points out, ambiguous implicits are a Scala trick that has been around for a while and are essentially folklore at this point (and specifically his gist shows usage of checking that a type is not |
Current coverage is 90.53% (diff: 100%)@@ master #1276 diff @@
==========================================
Files 243 243
Lines 3285 3286 +1
Methods 3228 3229 +1
Messages 0 0
Branches 55 55
==========================================
Hits 2975 2975
- Misses 310 311 +1
Partials 0 0
|
|
👍 |
1 similar comment
|
👍 |
|
Thanks for the effort @ceedubs and @adelbertc, appreciated! Just giving my opinion here as Adelbert did ask for it, just keep in mind that with only 4 commits I do not consider myself as a scalaz7 contributor at all. That being said, in the process of writing a functional library that is fast, I steel ideas from @non whenever I can, and I would expect anybody to do the same with all the great ideas appearing in the diversity of open source projects around. I like what you are doing here in term of attribution, and in essence it's how I did it (https://github.com/scalaz/scalaz/blob/series/8.0.x/meta/src/main/scala/Ops.scala#L6), once we'll move forward formalizing more the approach, I'll definitely push into following a similar process as the one put in place here. 👍 |
|
@aloiscochard thank you, I really appreciate the feedback. I'm going to go ahead and merge this, and if @puffnfresh has any further feedback, I can address it in a separate PR. |
This is inspired by #1275. It doesn't include a CLA, and there is
most likely more work that should be done with respect to attribution,
but I'm hoping that this is a step in the right direction.
I've added a link to the scalaz contributors page within AUTHORS.md.
I'm not sure who all out of that should and would want to be directly listed
in the authors page for Cats. I've explicitly added Brian McKenna to the
authors page, as my understanding of this
tweet is that
he would like to be on there.
@puffnfresh, if you care to, please let me know if there is any way that I could improve this.