Add XorT.toValidatedNel #1188
Merged
Add XorT.toValidatedNel #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -157,6 +157,9 @@ final case class XorT[F[_], A, B](value: F[A Xor B]) { | |||
| def toValidated(implicit F: Functor[F]): F[Validated[A, B]] = | |||
| F.map(value)(_.toValidated) | |||
|
|
|||
| def toValidatedNel(implicit F: Functor[F]): F[ValidatedNel[A,B]] = | |||
There was a problem hiding this comment.
Scalastyle wants there to be a space after the comma: ValidatedNel[A, B]
|
I like it. Thanks @markus1189. 👍 after the minor formatting issue is addressed and Scalastyle is happy. |
markus1189
force-pushed
the
xort-tovalidatednel
branch
from
2271d65
to
32438a9
Compare
Current coverage is 88.81%@@ master #1188 diff @@
==========================================
Files 233 233
Lines 3084 3085 +1
Methods 3033 3032 -1
Messages 0 0
Branches 48 50 +2
==========================================
+ Hits 2739 2740 +1
Misses 345 345
Partials 0 0
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is only
.toValidated, but I frequently needtoValidatedNelas well, so here it is ;)